Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump ArnolidMethod #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bump ArnolidMethod #203

wants to merge 1 commit into from

Conversation

etiennedeg
Copy link
Member

@etiennedeg etiennedeg commented Jul 17, 2024 •
edited
Loading

closes #202

@j-fu
Copy link

j-fu commented Jul 19, 2024

Thanks for this PR ! Would really appreciate to see this accepted.

@dehann dehann mentioned this pull request Aug 10, 2024
Open
@newptcai
Copy link

This has stopped update Graphs.jl. Hope this can be fixed and merged.

@simonschoelly
Copy link
Contributor

Failing tests might be related to JuliaPlots/VisualRegressionTests.jl#30.

@simonschoelly simonschoelly mentioned this pull request Sep 30, 2024
Open
@simonschoelly
Copy link
Contributor

It looks like we are trying to open a popup when the tests are not run on travis, e.g.

GraphPlot.jl/test/runtests.jl

Line 67 in 3a7daa0

@test test_images(VisualTest(plot_and_save1, refimg1), popup=!istravis) |> save_comparison |> success

But we are not running these tests on travis anymore, so we might change that.

@simonschoelly
Copy link
Contributor

The right env variable might be GITHUB_ACTIONS https://stackoverflow.com/questions/73973332/check-if-were-in-a-github-action-travis-ci-circle-ci-etc-testing-environme#answer-73973555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Compatibility issue when used alongside Graph, ArnoldiMethod v0.4 required
4 participants
@etiennedeg @j-fu @newptcai @simonschoelly